linux-kernel - Re: [Linux-stm32] [PATCH 5/5] dmaengine: stm32-dma: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jul 2023 09:33:14 +0200
From:   Amelie Delaunay <amelie.delaunay@...s.st.com>
To:     Yangtao Li <frank.li@...o.com>, Vinod Koul <vkoul@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>
CC:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [Linux-stm32] [PATCH 5/5] dmaengine: stm32-dma: Use
 devm_platform_get_and_ioremap_resource()



On 7/5/23 10:18, Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Amelie Delaunay <amelie.delaunay@...s.st.com>
Tested-by: Amelie Delaunay <amelie.delaunay@...s.st.com>

> ---
>   drivers/dma/stm32-dma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c
> index 37674029cb42..5c36811aa134 100644
> --- a/drivers/dma/stm32-dma.c
> +++ b/drivers/dma/stm32-dma.c
> @@ -1581,8 +1581,7 @@ static int stm32_dma_probe(struct platform_device *pdev)
>   
>   	dd = &dmadev->ddev;
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dmadev->base = devm_ioremap_resource(&pdev->dev, res);
> +	dmadev->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>   	if (IS_ERR(dmadev->base))
>   		return PTR_ERR(dmadev->base);
>