[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a8c6e741a9c704dad9b63e1e85136a8e6da09b44.camel@redhat.com>
Date: Thu, 06 Jul 2023 09:53:53 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Yu Hao <yhao016@....edu>, kvalo@...nel.org, keescook@...omium.org,
gustavoars@...nel.org, Jason@...c4.com,
linux-wireless@...r.kernel.org,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: wireless: cisco: Fix possible uninit bug
On Tue, 2023-07-04 at 16:50 -0700, Yu Hao wrote:
> The struct cap_rid should be initialized by function readCapabilityRid.
> However, there is not return value check. Iit is possible that
> the function readCapabilityRid returns error code and cap_rid.softCap
> is not initialized. But there is a read later for this field.
>
> Signed-off-by: Yu Hao <yhao016@....edu>
> ---
> drivers/net/wireless/cisco/airo.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/airo.c
> b/drivers/net/wireless/cisco/airo.c
> index 7c4cc5f5e1eb..b3736d76a5d5 100644
> --- a/drivers/net/wireless/cisco/airo.c
> +++ b/drivers/net/wireless/cisco/airo.c
> @@ -6950,8 +6950,11 @@ static int airo_get_range(struct net_device *dev,
> CapabilityRid cap_rid; /* Card capability info */
> int i;
> int k;
> + int status;
>
> - readCapabilityRid(local, &cap_rid, 1);
> + status = readCapabilityRid(local, &cap_rid, 1);
> + if (status != SUCCESS)
> + return ERROR;
This value is returned directly to the network stack, you must use a
standard error code instead (e.g. -EINVAL).
Also, please add a suitable 'Fixes' tag, thanks!
Paolo
Powered by blists - more mailing lists