linux-kernel - Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in svc_create_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <083cfb82-84cd-417d-b5ac-2b831b24710e@kadam.mountain>
Date:   Thu, 6 Jul 2023 11:28:25 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Wang Ming <machel@...o.com>, kernel-janitors@...r.kernel.org,
        Dinh Nguyen <dinguyen@...nel.org>, opensource.kernel@...o.com,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in
 svc_create_memory_pool()

On Wed, Jul 05, 2023 at 08:21:02PM +0200, Markus Elfring wrote:
> Please apply a more appropriate patch subject.
> 

Markus, a number of people have asked you to stop with this nonsense.

> 
> > The devm_memremap() function returns error pointers.
> > It never returns NULL. Fix the check.
> 
> Would the following wording be helpful?
> 
> 
>   Replace a null pointer check by an error pointer check after a call
>   of the function “devm_memremap” in this function implementation.

No.  The original was fine.  The original commit message is more clear
than your proposed commit message.

regards,
dan carpenter