[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230706085839.31145-1-jiasheng@iscas.ac.cn>
Date: Thu, 6 Jul 2023 16:58:39 +0800
From: Jiasheng Jiang <jiasheng@...as.ac.cn>
To: ira.weiny@...el.com, dan.j.williams@...el.com,
vishal.l.verma@...el.com, dave.jiang@...el.com, oohall@...il.com,
aneesh.kumar@...ux.ibm.com
Cc: nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: [PATCH v3] libnvdimm/of_pmem: Replace kstrdup with devm_kstrdup and add check
Replace kstrdup() with devm_kstrdup() to avoid memory leak and
add check for the return value of the devm_kstrdup() to avoid
NULL pointer dereference
Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
---
Changelog:
v2 -> v3:
1. Correct the usage of devm_kstrdup().
v1 -> v2:
1. Replace kstrdup() with devm_kstrdup().
---
drivers/nvdimm/of_pmem.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
index 10dbdcdfb9ce..1d2b1ab5b737 100644
--- a/drivers/nvdimm/of_pmem.c
+++ b/drivers/nvdimm/of_pmem.c
@@ -30,7 +30,12 @@ static int of_pmem_region_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;
- priv->bus_desc.provider_name = kstrdup(pdev->name, GFP_KERNEL);
+ priv->bus_desc.provider_name = devm_kstrdup(&pdev->dev, pdev->name, GFP_KERNEL);
+ if (!priv->bus_desc.provider_name) {
+ kfree(priv);
+ return -ENOMEM;
+ }
+
priv->bus_desc.module = THIS_MODULE;
priv->bus_desc.of_node = np;
--
2.25.1
Powered by blists - more mailing lists