linux-kernel - Re: [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529beea3-3f36-3837-35c4-1efa25d8f1f2@linaro.org>
Date:   Thu, 6 Jul 2023 12:57:04 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rohit Agarwal <quic_rohiagar@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: power: rpmpd: Remove the SoC specific
 entries

On 06/07/2023 12:53, Rohit Agarwal wrote:
> 
> On 7/6/2023 4:15 PM, Krzysztof Kozlowski wrote:
>> On 06/07/2023 11:20, Rohit Agarwal wrote:
>>> Remove the SoC specific entries and add a generic set of defines
>>> that can be used by all the SoCs. This will remove the duplicate
>>> entries among SoCs.
>>> The arrangement of the defines is done according to the frequency
>>> used in SoC specific entries in the driver to avoid wastage of
>>> memory.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@...cinc.com>
>>> Suggested-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>> Please compile kernel with this commit and tell us what is wrong... Even
>> if bindings were not an ABI, but they are, this would not work.
> Do you mean that individually this commit would fail compilation?
> Yes, we would need all the patches together for compilation to be 
> successful.

Yeah, it is not bisectable.

Another problem is ABI impact, but I think Konrad covered it.

Best regards,
Krzysztof