linux-kernel - Re: [PATCH v2 44/92] fat: convert to ctime accessor functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f8c9bed3fb3ad9cfb64e008eb6a6e96b020200e.camel@kernel.org>
Date:   Thu, 06 Jul 2023 07:25:48 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     Christian Brauner <brauner@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 44/92] fat: convert to ctime accessor functions

On Thu, 2023-07-06 at 10:54 +0900, OGAWA Hirofumi wrote:
> Jeff Layton <jlayton@...nel.org> writes:
> 
> > @@ -1407,8 +1407,9 @@ static int fat_read_root(struct inode *inode)
> >  	MSDOS_I(inode)->mmu_private = inode->i_size;
> >  
> >  	fat_save_attrs(inode, ATTR_DIR);
> > -	inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode->i_ctime.tv_sec = 0;
> > -	inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = 0;
> > +	inode->i_mtime.tv_sec = inode->i_atime.tv_sec = inode_set_ctime(inode,
> > +									0, 0).tv_sec;
> > +	inode->i_mtime.tv_nsec = inode->i_atime.tv_nsec = 0;
> 
> Maybe, this should simply be
> 
> 	inode->i_mtime = inode->i_atime = inode_set_ctime(inode, 0, 0);
> 

Yes, that would be clearer. Chalk that one up to the automated
coccinelle conversion. I've fixed it in my ctime-next branch.

Thanks!
-- 
Jeff Layton <jlayton@...nel.org>