linux-kernel - Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 06 Jul 2023 12:33:06 +0100
From:   Christopher Obbard <chris.obbard@...labora.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-rockchip@...ts.infradead.org
Cc:     kernel@...labora.com, Andy Yan <andyshrk@....com>,
        Chris Morgan <macromorgan@...mail.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Jagan Teki <jagan@...eble.ai>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maya Matuszczyk <maccraft123mc@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sebastian.reichel@...labora.com>,
        Tianling Shen <cnsztl@...il.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/3] arm64: dts: rockchip: Add Radxa ROCK 4SE

Hi Krzysztof,

On Wed, 2023-07-05 at 17:53 +0200, Krzysztof Kozlowski wrote:
> On 05/07/2023 16:10, Christopher Obbard wrote:
> > Add board-specific devicetree file for the RK3399T-based Radxa ROCK 4SE
> > board. This board offers similar peripherals in a similar form-factor to
> > the existing ROCK Pi 4B but uses the cost-optimised RK3399T processor
> > (which has different OPP table than the RK3399) and other minimal hardware
> > changes.
> > 
> > Signed-off-by: Christopher Obbard <chris.obbard@...labora.com>
> > ---
> > 
> 
> 
> > +
> > +&sdio0 {
> > +       status = "okay";
> > +
> > +       brcmf: wifi@1 {
> > +               compatible = "brcm,bcm4329-fmac";
> > +               reg = <1>;
> > +               interrupt-parent = <&gpio0>;
> > +               interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>;
> 
> I just send a patch to fix this in some files, so let's try keep it
> good. Use proper interrupt type, not none.

Thank you for your review. I missed that patch, sent only a few hours before mine. I will address this in v2.


Cheers!

Chris