linux-kernel - Re: [PATCH V2 net 0/4] net: fec: fix some issues of ndo_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Jul 2023 13:51:23 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     <wei.fang@....com>
CC:     <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <ast@...nel.org>, <daniel@...earbox.net>,
        <hawk@...nel.org>, <john.fastabend@...il.com>,
        <shenwei.wang@....com>, <xiaoning.wang@....com>,
        <netdev@...r.kernel.org>, <linux-imx@....com>,
        <linux-kernel@...r.kernel.org>, <bpf@...r.kernel.org>
Subject: Re: [PATCH V2 net 0/4] net: fec: fix some issues of ndo_xdp_xmit()

From: Wei Fang <wei.fang@....com>
Date: Thu,  6 Jul 2023 16:10:08 +0800

> From: Wei Fang <wei.fang@....com>

Please sync your Git commit author settings wrt Git email settings, so
that there wouldn't be "From:" for your own commits.

> 
> We encountered some issues when testing the ndo_xdp_xmit() interface
> of the fec driver on i.MX8MP and i.MX93 platforms. These issues are
> easy to reproduce, and the specific reproduction steps are as follows.
> 
> step1: The ethernet port of a board (board A) is connected to the EQOS
> port of i.MX8MP/i.MX93, and the FEC port of i.MX8MP/i.MX93 is connected
> to another ethernet port, such as a switch port.
> 
> step2: Board A uses the pktgen_sample03_burst_single_flow.sh to generate
> and send packets to i.MX8MP/i.MX93. The command is shown below.
> ./pktgen_sample03_burst_single_flow.sh -i eth0 -d 192.168.6.8 -m \
> 56:bf:0d:68:b0:9e -s 1500
> 
> step3: i.MX8MP/i.MX93 use the xdp_redirect bfp program to redirect the
> XDP frames from EQOS port to FEC port. The command is shown below.
> ./xdp_redirect eth1 eth0
> 
> After a few moments, the warning or error logs will be printed in the
> console, for more details, please refer to the commit message of each
> patch.
> 
> Wei Fang (4):
>   net: fec: dynamically set the NETDEV_XDP_ACT_NDO_XMIT feature of XDP
>   net: fec: recycle pages for transmitted XDP frames
>   net: fec: increase the size of tx ring and update tx_wake_threshold
>   net: fec: use netdev_err_once() instead of netdev_err()
> 
>  drivers/net/ethernet/freescale/fec.h      |  17 ++-
>  drivers/net/ethernet/freescale/fec_main.c | 166 +++++++++++++++-------
>  2 files changed, 127 insertions(+), 56 deletions(-)
Thanks,
Olek