linux-kernel - Re: [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto tags from raid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37c7a3f7-f769-a313-3279-e8e415369ba4@molgen.mpg.de>
Date:   Thu, 6 Jul 2023 15:01:05 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     agk@...hat.com, snitzer@...nel.org, dm-devel@...hat.com,
        song@...nel.org, heinzm@...hat.com, neilb@...e.de,
        jbrassow@...hat.com, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org, yukuai3@...wei.com,
        yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next 2/3] md/dm-raid: cleanup multiple equivalent goto
 tags from raid_ctr()

Dear Yu,


Thank you for your patch. Some minor nits, if you are interested.

Am 06.07.23 um 09:16 schrieb Yu Kuai:
> From: Yu Kuai <yukuai3@...wei.com>
> 
> There are four equivalent goto tags in raid_ctr(), clean them up to use
> just one, there are no functional change and prepare to fix that

Maybe:

There *is* no functional change, and is a preparation to fix an 
unprotected `md_stop()`.

> md_stop() is not protected.

In the commit message summary/title, I’d spell the verb with a space:

     Clean up four equivalent goto tags in raid_ctr()

> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> ---
>   drivers/md/dm-raid.c | 27 +++++++++------------------
>   1 file changed, 9 insertions(+), 18 deletions(-)

[…]


Kind regards,

Paul