linux-kernel - Re: [PATCH v2 53/92] isofs: convert to ctime accessor functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3005cad61ff0f2de38150d50584c85017df0c57.camel@kernel.org>
Date:   Thu, 06 Jul 2023 09:11:25 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Christian Brauner <brauner@...nel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 53/92] isofs: convert to ctime accessor functions

On Thu, 2023-07-06 at 14:39 +0200, Jan Kara wrote:
> On Wed 05-07-23 15:01:18, Jeff Layton wrote:
> > In later patches, we're going to change how the inode's ctime field is
> > used. Switch to using accessor functions instead of raw accesses of
> > inode->i_ctime.
> > 
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> > ---
> >  fs/isofs/inode.c |  8 ++++----
> >  fs/isofs/rock.c  | 16 +++++++---------
> >  2 files changed, 11 insertions(+), 13 deletions(-)
> > 
> > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> > index df9d70588b60..98a78200cff1 100644
> > --- a/fs/isofs/inode.c
> > +++ b/fs/isofs/inode.c
> > @@ -1424,11 +1424,11 @@ static int isofs_read_inode(struct inode *inode, int relocated)
> >  #endif
> >  
> >  	inode->i_mtime.tv_sec =
> > -	inode->i_atime.tv_sec =
> > -	inode->i_ctime.tv_sec = iso_date(de->date, high_sierra);
> > +	inode->i_atime.tv_sec = inode_set_ctime(inode,
> > +						iso_date(de->date, high_sierra),
> > +						0).tv_sec;
> >  	inode->i_mtime.tv_nsec =
> > -	inode->i_atime.tv_nsec =
> > -	inode->i_ctime.tv_nsec = 0;
> > +	inode->i_atime.tv_nsec = 0;
> 
> This would be IMHO more readable as:
> 
> 	inode->i_mtime = inode->i_atime =
> 		inode_set_ctime(inode, iso_date(de->date, high_sierra), 0);
> 
> 
> Otherwise the patch looks good.
> 

Thanks. Fixed in my tree.
-- 
Jeff Layton <jlayton@...nel.org>