linux-kernel - Re: [PATCH v2] perf vendor events amd: Fix large metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce15f15b-2f1d-960c-c20e-131d92e1d750@amd.com>
Date:   Thu, 6 Jul 2023 19:52:09 +0530
From:   Sandipan Das <sandipan.das@....com>
To:     Ian Rogers <irogers@...gle.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        jolsa@...nel.org, namhyung@...nel.org, adrian.hunter@...el.com,
        ayush.jain3@....com, ananth.narayan@....com, ravi.bangoria@....com,
        santosh.shukla@....com
Subject: Re: [PATCH v2] perf vendor events amd: Fix large metrics

Hi Ian,

On 7/6/2023 7:19 PM, Ian Rogers wrote:
> On Wed, Jul 5, 2023 at 11:34 PM Sandipan Das <sandipan.das@....com> wrote:
>>
>> There are cases where a metric requires more events than the number of
>> available counters. E.g. AMD Zen, Zen 2 and Zen 3 processors have four
>> data fabric counters but the "nps1_die_to_dram" metric has eight events.
>> By default, the constituent events are placed in a group and since the
>> events cannot be scheduled at the same time, the metric is not computed.
>> The "all metrics" test also fails because of this.
>>
>> Use the NO_GROUP_EVENTS constraint for such metrics which anyway expect
>> the user to run perf with "--metric-no-group".
>>
>> E.g.
>>
>>   $ sudo perf test -v 101
>>
>> Before:
>>
>>   101: perf all metrics test                                           :
>>   --- start ---
>>   test child forked, pid 37131
>>   Testing branch_misprediction_ratio
>>   Testing all_remote_links_outbound
>>   Testing nps1_die_to_dram
>>   Metric 'nps1_die_to_dram' not printed in:
>>   Error:
>>   Invalid event (dram_channel_data_controller_4) in per-thread mode, enable system wide with '-a'.
>>   Testing macro_ops_dispatched
>>   Testing all_l2_cache_accesses
>>   Testing all_l2_cache_hits
>>   Testing all_l2_cache_misses
>>   Testing ic_fetch_miss_ratio
>>   Testing l2_cache_accesses_from_l2_hwpf
>>   Testing l2_cache_misses_from_l2_hwpf
>>   Testing op_cache_fetch_miss_ratio
>>   Testing l3_read_miss_latency
>>   Testing l1_itlb_misses
>>   test child finished with -1
>>   ---- end ----
>>   perf all metrics test: FAILED!
>>
>> After:
>>
>>   101: perf all metrics test                                           :
>>   --- start ---
>>   test child forked, pid 43766
>>   Testing branch_misprediction_ratio
>>   Testing all_remote_links_outbound
>>   Testing nps1_die_to_dram
>>   Testing macro_ops_dispatched
>>   Testing all_l2_cache_accesses
>>   Testing all_l2_cache_hits
>>   Testing all_l2_cache_misses
>>   Testing ic_fetch_miss_ratio
>>   Testing l2_cache_accesses_from_l2_hwpf
>>   Testing l2_cache_misses_from_l2_hwpf
>>   Testing op_cache_fetch_miss_ratio
>>   Testing l3_read_miss_latency
>>   Testing l1_itlb_misses
>>   test child finished with 0
>>   ---- end ----
>>   perf all metrics test: Ok
>>
>> Reported-by: Ayush Jain <ayush.jain3@....com>
>> Suggested-by: Ian Rogers <irogers@...gle.com>
>> Signed-off-by: Sandipan Das <sandipan.das@....com>
> 
> Acked-by: Ian Rogers <irogers@...gle.com>
> 
> Will there be a PMU driver fix so that the perf_event_open fails for
> the group? That way the weak group would work.
> 

Yes, that's in our plan. Ravi (in CC) and I have discussed about adding
group validation in the event_init() path.

- Sandipan