linux-kernel - Re: [PATCH v3] wifi: ath9k: fix printk specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=kccbUFGsWMA_31UPW6p=k1qa+HyL5OGyzv50W2Mc111w@mail.gmail.com>
Date:   Thu, 6 Jul 2023 18:04:54 +0200
From:   Jonas Gorski <jonas.gorski@...il.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     Dongliang Mu <dzm91@...t.edu.cn>, Kalle Valo <kvalo@...nel.org>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] wifi: ath9k: fix printk specifier

On Thu, 6 Jul 2023 at 13:39, Toke Høiland-Jørgensen <toke@...e.dk> wrote:
>
> Dongliang Mu <dzm91@...t.edu.cn> writes:
>
> > Smatch reports:
> >
> > ath_pci_probe() warn: argument 4 to %lx specifier is cast from pointer
> > ath_ahb_probe() warn: argument 4 to %lx specifier is cast from pointer
> >
> > Fix it by modifying %lx to %p in printk.
> >
> > Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
>
> Third time is the charm! :)
>
> Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>

But do we *want* to replace %lx with %p? Because this now causes a
change in behavior, as the kernel will omit the pointer's address,
while before it printed the actual memory address. Using %px would
have kept the original behavior.

So if the change is desired, it should be noted in the commit message.

best Regards,
Jonas