linux-kernel - Re: [PATCH] x86/shstk: Move arch detail comment out of core mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9704b6a9-e7c5-4d50-9567-9e23906aafdf@sirena.org.uk>
Date:   Fri, 7 Jul 2023 16:08:20 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Rick Edgecombe <rick.p.edgecombe@...el.com>
Cc:     akpm@...ux-foundation.org, andrew.cooper3@...rix.com,
        arnd@...db.de, bp@...en8.de, bsingharora@...il.com,
        christina.schimpe@...el.com, corbet@....net,
        dave.hansen@...ux.intel.com, david@...hat.com, debug@...osinc.com,
        dethoma@...rosoft.com, eranian@...gle.com, esyr@...hat.com,
        fweimer@...hat.com, gorcunov@...il.com, hjl.tools@...il.com,
        hpa@...or.com, jamorris@...ux.microsoft.com, jannh@...gle.com,
        john.allen@....com, kcc@...gle.com, keescook@...omium.org,
        kirill.shutemov@...ux.intel.com, linux-api@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org, luto@...nel.org,
        mike.kravetz@...cle.com, mingo@...hat.com, nadav.amit@...il.com,
        oleg@...hat.com, pavel@....cz, pengfei.xu@...el.com,
        peterz@...radead.org, rdunlap@...radead.org, rppt@...nel.org,
        szabolcs.nagy@....com, tglx@...utronix.de,
        torvalds@...ux-foundation.org, weijiang.yang@...el.com,
        willy@...radead.org, x86@...nel.org, yu-cheng.yu@...el.com
Subject: Re: [PATCH] x86/shstk: Move arch detail comment out of core mm

On Thu, Jul 06, 2023 at 04:32:48PM -0700, Rick Edgecombe wrote:
> The comment around VM_SHADOW_STACK in mm.h refers to a lot of x86
> specific details that don't belong in a cross arch file. Remove these
> out of core mm, and just leave the non-arch details.
> 
> Since the comment includes some useful details that would be good to
> retain in the source somewhere, put the arch specifics parts in
> arch/x86/shstk.c near alloc_shstk(), where memory of this type is
> allocated. Include a reference to the existence of the x86 details near
> the VM_SHADOW_STACK definition mm.h.

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)