linux-kernel - Re: [PATCH] Add struct ad9832_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023070858-brewing-outpour-764c@gregkh>
Date:   Sat, 8 Jul 2023 13:10:29 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Madhumitha Prabakaran <madhumithabiw@...il.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-staging@...ts.linux.dev, skhan@...uxfoundation.org,
        ivan.orlov0322@...il.com
Subject: Re: [PATCH] Add struct ad9832_platform_data to the include/linux/iio

On Fri, Jul 07, 2023 at 04:15:53PM -0500, Madhumitha Prabakaran wrote:
> Add struct ad9832_platform_data to the include/linux/iio
> for maintaining code organization and clarity.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@...il.com>
> ---
>  drivers/staging/iio/frequency/ad9832.c |  3 +--
>  drivers/staging/iio/frequency/ad9832.h | 34 --------------------------
>  include/linux/iio/frequency/ad9832.h   | 30 +++++++++++++++++++++++

No, not yet, sorry.  Staging drivers should be self-contained, why does
this .c file need a .h file at all anyway?  It should all just be in the
.c file, can you do that instead?

thanks,

greg k-h