linux-kernel - Re: [PATCH] iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <560ddda0-338c-533b-35c5-58483ae0cea0@linaro.org>
Date:   Sat, 8 Jul 2023 16:45:28 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: qcom-spmi-adc5: Add ADC5_GPIO2_100K_PU

On 8.07.2023 16:29, Jonathan Cameron wrote:
> On Tue, 27 Jun 2023 03:08:20 +0300
> Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:
> 
>> On 27/06/2023 02:21, Konrad Dybcio wrote:
>>> Even though it existed in bindings for the longest time,
>>> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>>>   drivers/iio/adc/qcom-spmi-adc5.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>   
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>
> I was a little unsure on this one. So far I've applied it as a 'feature'
> so it's in the normal iio togreg branch, but perhaps it should be a fix?
I suppose it's a feature as it's never been used before

Konrad
> 
> For now applied to the togreg branch of iio.git but given I'll be rebasing
> that on rc1, for now it's only visible as testing.  0-day can play with that
> in the meantime and see if it can find any issues
> 
> Jonathan
> 
>