[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1688788886-94279-1-git-send-email-mikelley@microsoft.com>
Date: Fri, 7 Jul 2023 21:01:26 -0700
From: Michael Kelley <mikelley@...rosoft.com>
To: kys@...rosoft.com, martin.petersen@...cle.com,
longli@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
jejb@...ux.ibm.com, linux-hyperv@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Cc: mikelley@...rosoft.com
Subject: [PATCH 1/1] scsi: storvsc: Handle SRB status value 0x30
In response to a disk I/O request, Hyper-V has been observed to return
SRB status value 0x30. This indicates the request was not processed
by Hyper-V because low memory conditions on the host caused an internal
error. The 0x30 status is not recognized by storvsc, so the I/O operation
is not flagged as an error. The request is treated as if it completed
normally but with zero data transferred, causing a flood of retries.
Add a definition for this SRB status value and handle it like
other error statuses from the Hyper-V host.
Signed-off-by: Michael Kelley <mikelley@...rosoft.com>
---
drivers/scsi/storvsc_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 659196a..7f12d93 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -318,6 +318,7 @@ enum storvsc_request_type {
#define SRB_STATUS_INVALID_REQUEST 0x06
#define SRB_STATUS_DATA_OVERRUN 0x12
#define SRB_STATUS_INVALID_LUN 0x20
+#define SRB_STATUS_INTERNAL_ERROR 0x30
#define SRB_STATUS(status) \
(status & ~(SRB_STATUS_AUTOSENSE_VALID | SRB_STATUS_QUEUE_FROZEN))
@@ -978,6 +979,7 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
case SRB_STATUS_ERROR:
case SRB_STATUS_ABORTED:
case SRB_STATUS_INVALID_REQUEST:
+ case SRB_STATUS_INTERNAL_ERROR:
if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID) {
/* Check for capacity change */
if ((asc == 0x2a) && (ascq == 0x9)) {
--
1.8.3.1
Powered by blists - more mailing lists