linux-kernel - Re: [PATCH] nvme-pci: Add suspend quirk for HP mt645 thin client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jul 2023 23:28:54 -0500
From:   "Limonciello, Mario" <mario.limonciello@....com>
To:     Alexandru Gagniuc <alexandru.gagniuc@...com>,
        linux-nvme@...ts.infradead.org
Cc:     kbusch@...nel.org, axboe@...com, hch@....de, sagi@...mberg.me,
        linux-kernel@...r.kernel.org, eniac-xw.zhang@...com,
        stable@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: Add suspend quirk for HP mt645 thin client


On 7/6/2023 1:06 PM, Alexandru Gagniuc wrote:
> The HP Elite mt645 thin client exhibits resume times of over one
> minute when using the normal nvme resume path.

Is this the specific product you're referring to?

https://www.amd.com/system/files/documents/hp-elite-mt645-g7-mobile-thin-client.pdf

> BIOS has tried to work
> around this by setting the "StorageD3Enable" ACPI property, but only
> if it detected the "Linux-HPI-Hybrid-Graphics" _OSI() flag. This flag
> does not exist, so the BIOS workaround can't work.
>
> Instead, just set NVME_QUIRK_SIMPLE_SUSPEND when running on an mt645.
> The DMI_PRODUCT_NAME cannot be used because this string can be changed
> in the field. Match against DMI_BOARD_NAME, which should be immutable.
I'm quite confused why this is necessary.  If the product link
I sent above is correct, this is an AMD Barcelo APU.

Cezanne and Barcelo report as the exact same X86 model.

Cezanne will already always identify as simple
suspend due to bugs that were reported on some other machines.
It's been this way since kernel 6.3-rc1.

e2a56364485e ("ACPI: x86: utils: Add Cezanne to the list for forcing 
StorageD3Enable")

>
> Cc: stable@...r.kernel.org
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@...com>
> ---
>   drivers/nvme/host/pci.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 492f319ebdf3..25b59f5ce874 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2897,6 +2897,15 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
>   		if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) &&
>   		     dmi_match(DMI_BOARD_NAME, "LNVNB161216"))
>   			return NVME_QUIRK_SIMPLE_SUSPEND;
> +	} else if (dmi_match(DMI_SYS_VENDOR, "HP") &&
> +		   (dmi_match(DMI_BOARD_NAME, "8B0F") ||
> +		    dmi_match(DMI_BOARD_NAME, "8B59"))) {
> +		/*
> +		 * Force simple suspend to work around long resume latencies
> +		 * (1 minute or longer).
> +		 */
> +		dev_info(&pdev->dev, "simple suspend quirk for HP mt645\n");
> +		return NVME_QUIRK_SIMPLE_SUSPEND;
>   	}
>   
>   	return 0;