linux-kernel - Re: [PATCH] dt-bindings: firmware: add reset-controller property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168892849854.136160.7620779203584875736.robh@kernel.org>
Date:   Sun, 09 Jul 2023 12:48:18 -0600
From:   Rob Herring <robh@...nel.org>
To:     Piyush Mehta <piyush.mehta@....com>
Cc:     nava.kishore.manne@....com, linux-kernel@...r.kernel.org,
        git@....com, wsa@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, broonie@...nel.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        dlemoal@...nel.org, michal.simek@....com,
        sebastian.reichel@...labora.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: add reset-controller property


On Sun, 09 Jul 2023 22:55:42 +0530, Piyush Mehta wrote:
> The reset controller is responsible for managing both device-level resets
> and individual PMC (Power Management Controller) block resets.
> 
> To facilitate this functionality reset-controller property is added to the
> firmware device tree binding.
> 
> Signed-off-by: Piyush Mehta <piyush.mehta@....com>
> ---
>  .../firmware/xilinx/xlnx,zynqmp-firmware.yaml         | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/reset/xlnx,zynqmp-reset.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: versal-firmware: reset-controller: False schema does not allow {'compatible': ['xlnx,zynqmp-reset'], '#reset-cells': [[1]]}
	from schema $id: http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml#
Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.example.dtb: /example-0/versal-firmware/reset-controller: failed to match any schema with compatible: ['xlnx,zynqmp-reset']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230709172542.1393828-1-piyush.mehta@amd.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.