linux-kernel - Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2023070919-monetary-sleet-2f5c@gregkh>
Date:   Sun, 9 Jul 2023 21:42:47 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Zhang Shurong <zhang_shurong@...mail.com>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Dan Carpenter <error27@...il.com>,
        Xu Panda <xu.panda@....com.cn>
Subject: Re: [PATCH] staging: ks7010: potential buffer overflow in
 ks_wlan_set_encode_ext()

On Sun, Jul 09, 2023 at 09:21:45PM +0200, Markus Elfring wrote:
> > The "exc->key_len" is a u16 that comes from the user.  If it's over
> > IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
> 
> Please choose an imperative change suggestion.

Please stop reviewing staging patches, it is not helpful for anyone.

greg k-h