linux-kernel - Re: [PATCH] Add struct ad9832_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52f47b43-e735-0be9-ebac-e6e099a2dd09@gmail.com>
Date:   Sun, 9 Jul 2023 18:40:20 -0500
From:   Madhumitha Prabakaran <madhumithabiw@...il.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        linux-staging@...ts.linux.dev, skhan@...uxfoundation.org,
        ivan.orlov0322@...il.com
Subject: Re: [PATCH] Add struct ad9832_platform_data to the include/linux/iio


On 7/8/23 09:45, Jonathan Cameron wrote:
> On Sat, 8 Jul 2023 13:10:29 +0200
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>
>> On Fri, Jul 07, 2023 at 04:15:53PM -0500, Madhumitha Prabakaran wrote:
>>> Add struct ad9832_platform_data to the include/linux/iio
>>> for maintaining code organization and clarity.
>>>
>>> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@...il.com>
>>> ---
>>>   drivers/staging/iio/frequency/ad9832.c |  3 +--
>>>   drivers/staging/iio/frequency/ad9832.h | 34 --------------------------
>>>   include/linux/iio/frequency/ad9832.h   | 30 +++++++++++++++++++++++
>> No, not yet, sorry.  Staging drivers should be self-contained, why does
>> this .c file need a .h file at all anyway?  It should all just be in the
>> .c file, can you do that instead?
> This is an aged driver so still has definitions that would be included
> from board files, hence the header.
>
> So Madhumitha, if you are looking at getting this driver out of staging
> (which would be great!) then first job is convert it from platform data
> to device tree (or better yet generic firmware bindings using linux/property.h)

Sure, I will take a look and work on convert it from platform data to 
generic

firmware bindings.

> A side effect of that is the header would go away as equivalent job would be
> done by the dt-bindings yaml file.
>
> Jonathan
>
>> thanks,
>>
>> greg k-h