[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230708174832.0af1d974cf67805dfc8ad655@linux-foundation.org>
Date: Sat, 8 Jul 2023 17:48:32 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Raul E Rangel <rrangel@...omium.org>
Cc: linux-kernel@...r.kernel.org, mario.limonciello@....com,
kramasub@...omium.org, Alexander Potapenko <glider@...gle.com>,
Ard Biesheuvel <ardb@...nel.org>,
"Jason A. Donenfeld" <Jason@...c4.com>,
Li Zhe <lizhe.67@...edance.com>,
"Liam R. Howlett" <Liam.Howlett@...cle.com>,
Mark Rutland <mark.rutland@....com>,
Will Deacon <will@...nel.org>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
Zhou jie <zhoujie@...china.com>
Subject: Re: [PATCH] init: Don't proxy console= to earlycon
On Fri, 7 Jul 2023 19:17:25 -0600 Raul E Rangel <rrangel@...omium.org> wrote:
> Right now we are proxying the `console=XXX` command line args to the
> param_setup_earlycon. This is done because the following are
> equivalent:
>
> console=uart[8250],mmio,<addr>[,options]
> earlycon=uart[8250],mmio,<addr>[,options]
>
> In addition, when `earlycon=` or just `earlycon` is specified on the
> command line, we look at the SPCR table or the DT to extract the device
> options.
>
> When `console=` is specified on the command line, it's intention is to
> disable the console. Right now since we are proxying the `console=`
> flag to the earlycon handler, we enable the earlycon_acpi_spcr_enable
> variable when an SPCR table is present. This means that we
> inadvertently enable the earlycon.
>
> This change makes it so we only proxy the console= command if it's
> value is not empty. This way we can correctly handle both cases.
>
I hope someone understands this ;)
Please "grep -r earlycon Documentation" and check for suitable places
to update our documentation.
Powered by blists - more mailing lists