[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <33712296-5887-d810-096b-c95cd718626d@samsung.com>
Date: Mon, 10 Jul 2023 16:41:12 +0200
From: Marek Szyprowski <m.szyprowski@...sung.com>
To: Yangtao Li <frank.li@...o.com>, Joerg Roedel <joro@...tes.org>,
Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>
Cc: iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] iommu/exynos: Convert to
devm_platform_ioremap_resource()
On 05.07.2023 15:04, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
> drivers/iommu/exynos-iommu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index c275fe71c4db..ab6208015997 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -725,19 +725,17 @@ static int exynos_sysmmu_probe(struct platform_device *pdev)
> int irq, ret;
> struct device *dev = &pdev->dev;
> struct sysmmu_drvdata *data;
> - struct resource *res;
>
> data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
> if (!data)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - data->sfrbase = devm_ioremap_resource(dev, res);
> + data->sfrbase = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(data->sfrbase))
> return PTR_ERR(data->sfrbase);
>
> irq = platform_get_irq(pdev, 0);
> - if (irq <= 0)
> + if (irq < 0)
> return irq;
>
> ret = devm_request_irq(dev, irq, exynos_sysmmu_irq, 0,
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Powered by blists - more mailing lists