linux-kernel - Re: [PATCH 8/8] of: make OF_EARLY_FLATTREE depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <168900051598.1946989.3367114616050746231.robh@kernel.org>
Date:   Mon, 10 Jul 2023 08:54:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     devicetree@...r.kernel.org, mturquette@...libre.com,
        kernel test robot <lkp@...el.com>,
        Jonathan.Cameron@...wei.com, maz@...nel.org, vkoul@...nel.org,
        dragan.cvetic@....com, edumazet@...gle.com, tglx@...utronix.de,
        tsbogend@...ha.franken.de, linux-kernel@...r.kernel.org,
        frowand.list@...il.com, eli.billauer@...il.com,
        derek.kiernan@....com, kuba@...nel.org, sboyd@...nel.org,
        schnelle@...ux.ibm.com, robh+dt@...nel.org,
        linus.walleij@...aro.org, arnd@...db.de, pabeni@...hat.com,
        davem@...emloft.net, linux-mm@...ck.org, akpm@...ux-foundation.org,
        linux@...inikbrodowski.net, gregkh@...uxfoundation.org,
        joyce.ooi@...el.com
Subject: Re: [PATCH 8/8] of: make OF_EARLY_FLATTREE depend on HAS_IOMEM


On Fri, 07 Jul 2023 21:58:52 +0800, Baoquan He wrote:
> On s390 systems (aka mainframes), it has classic channel devices for
> networking and permanent storage that are currently even more common
> than PCI devices. Hence it could have a fully functional s390 kernel
> with CONFIG_PCI=n, then the relevant iomem mapping functions
> [including ioremap(), devm_ioremap(), etc.] are not available.
> 
> In LKP error report at below on s390:
> ------
> ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
> coherent.c:(.text+0x102): undefined reference to `memremap'
> ld: coherent.c:(.text+0x226): undefined reference to `memunmap'
> ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
> coherent.c:(.text+0x8b8): undefined reference to `memunmap'
> ld: kernel/dma/coherent.o: in function `dma_release_coherent_memory':
> coherent.c:(.text+0x9aa): undefined reference to `memunmap'
> ------
> 
> In the config file, several Kconfig options are:
> ------
> '# CONFIG_PCI is not set'
> CONFIG_OF_EARLY_FLATTREE=y
> CONFIG_DMA_DECLARE_COHERENT=y
> ------
> 
> So, enabling OF_EARLY_FLATTREE will select DMA_DECLARE_COHERENT
> and cause above building errors even though they are not needed
> because CONFIG_PCI is disabled.
> 
> Here let OF_EARLY_FLATTREE depend on HAS_IOMEM so that it won't
> be built to cause compiling error if PCI is unset.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
> Signed-off-by: Baoquan He <bhe@...hat.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Frank Rowand <frowand.list@...il.com>
> Cc: devicetree@...r.kernel.org
> ---
>  drivers/of/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks!