[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <31140448-98c6-41a8-b3bc-de8e5a17da3a@sirena.org.uk>
Date: Mon, 10 Jul 2023 16:54:49 +0100
From: Mark Brown <broonie@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v1 1/1] regmap: spi: Use spi_message_init_with_transfers()
On Mon, Jul 10, 2023 at 06:01:47PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 10, 2023 at 03:38:55PM +0100, Mark Brown wrote:
>
> > > + spi_message_init_with_transfers(&async->m, async->t, val ? 2 : 1);
> > I'm not sure this is a legibility win.
> Fair enough. Since it's not an inlined call, ion x86_64 it gives +64 bytes
> to the code.
> Let's drop it.
Sure. The ones without the ternery operator are fine.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists