linux-kernel - Re: [PATCH] soc: aspeed: uart-routing: Use __sysfs_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 04:22:18 +0000
From:   Joel Stanley <joel@....id.au>
To:     Zev Weiss <zev@...ilderbeest.net>
Cc:     Andrew Jeffery <andrew@...id.au>, linux-aspeed@...ts.ozlabs.org,
        Chia-Wei Wang <chiawei_wang@...eedtech.com>,
        Oskar Senft <osk@...gle.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        openbmc@...ts.ozlabs.org
Subject: Re: [PATCH] soc: aspeed: uart-routing: Use __sysfs_match_string

On Wed, 28 Jun 2023 at 08:43, Zev Weiss <zev@...ilderbeest.net> wrote:
>
> The existing use of match_string() caused it to reject 'echo foo' due
> to the implicitly appended newline, which was somewhat ergonomically
> awkward and inconsistent with typical sysfs behavior.  Using the
> __sysfs_* variant instead provides more convenient and consistent
> linefeed-agnostic behavior.

Nice.

Fixes: c6807970c3bc ("soc: aspeed: Add UART routing support")
Reviewed-by: Joel Stanley <joel@....id.au>

>
> Signed-off-by: Zev Weiss <zev@...ilderbeest.net>
> ---
>  drivers/soc/aspeed/aspeed-uart-routing.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/aspeed/aspeed-uart-routing.c b/drivers/soc/aspeed/aspeed-uart-routing.c
> index ef8b24fd1851..59123e1f27ac 100644
> --- a/drivers/soc/aspeed/aspeed-uart-routing.c
> +++ b/drivers/soc/aspeed/aspeed-uart-routing.c
> @@ -524,7 +524,7 @@ static ssize_t aspeed_uart_routing_store(struct device *dev,
>         struct aspeed_uart_routing_selector *sel = to_routing_selector(attr);
>         int val;
>
> -       val = match_string(sel->options, -1, buf);
> +       val = __sysfs_match_string(sel->options, -1, buf);
>         if (val < 0) {
>                 dev_err(dev, "invalid value \"%s\"\n", buf);
>                 return -EINVAL;
> --
> 2.40.0.5.gf6e3b97ba6d2.dirty
>