linux-kernel - Re: [PATCH] of: Preserve "of-display" device name for compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230710174654.GB9196@kitsune.suse.cz>
Date:   Mon, 10 Jul 2023 19:46:54 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Rob Herring <robh@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        stable@...r.kernel.org, Cyril Brulebois <cyril@...amax.com>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Helge Deller <deller@....de>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: Preserve "of-display" device name for compatibility

On Mon, Jul 10, 2023 at 11:40:07AM -0600, Rob Herring wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.N" as required.
> 
> This means that offb no longer finds the expected device, which prevents
> the Debian Installer from setting up its interface, at least on ppc64el.
> 
> Fix this by keeping "of-display" for the first device and "of-display.N"
> for subsequent devices.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
> Link: https://bugs.debian.org/1033058
> Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
> Cc: stable@...r.kernel.org
> Cc: Cyril Brulebois <cyril@...amax.com>
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Helge Deller <deller@....de>
> Signed-off-by: Rob Herring <robh@...nel.org>

This is exclusive with the other patchset that updates the other side:
https://lore.kernel.org/lkml/20230412095509.2196162-1-cyril@debamax.com/

Reviewed-by: Michal Suchánek <msuchanek@...e.de>

Thanks

Michal

> ---
>  drivers/of/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 051e29b7ad2b..0c3475e7d2ff 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -552,7 +552,7 @@ static int __init of_platform_default_populate_init(void)
>  			if (!of_get_property(node, "linux,opened", NULL) ||
>  			    !of_get_property(node, "linux,boot-display", NULL))
>  				continue;
> -			dev = of_platform_device_create(node, "of-display.0", NULL);
> +			dev = of_platform_device_create(node, "of-display", NULL);
>  			of_node_put(node);
>  			if (WARN_ON(!dev))
>  				return -ENOMEM;
> -- 
> 2.40.1
>