linux-kernel - Re: [PATCH] media: dt-bindings: Convert Omnivision OV7251 to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230710-octane-disarray-44b363c02f73@spud>
Date:   Mon, 10 Jul 2023 19:20:31 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Todor Tomov <todor.too@...il.com>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dt-bindings: Convert Omnivision OV7251 to DT
 schema

On Mon, Jul 10, 2023 at 12:03:38PM -0600, Rob Herring wrote:
> On Mon, Jul 10, 2023 at 11:57 AM Conor Dooley <conor@...nel.org> wrote:
> >
> > On Fri, Jul 07, 2023 at 03:06:46PM -0600, Rob Herring wrote:
> > > Convert the OmniVision OV7251 Image Sensor binding to DT schema format.
> > >
> > > vddd-supply was listed as required, but the example and actual user
> > > don't have it. Also, the data brief says it has an internal regulator,
> > > so perhaps it is truly optional.
> >
> > ov7251.c:
> >         ov7251->core_regulator = devm_regulator_get(dev, "vddd");
> >         if (IS_ERR(ov7251->core_regulator)) {
> >                 dev_err(dev, "cannot get core regulator\n");
> >                 return PTR_ERR(ov7251->core_regulator);
> >         }
> >
> > Looks like the driver's probe function disagrees?
> 
> Doesn't the regulator framework return a dummy regulator if missing?

Huh, I think I misunderstood how _regulator_get() worked. Apologies for
the noise, I thought it was returning an error when it used a dummy.

> > I was going to ask how it worked, but the one user has
> > status = "disabled"...
> 
> Saw that too, but figured there's some other include with that
> overridden. We should really add a built .dts output target to avoid
> trying to manually walk includes.

Probably gonna sound like an eejit, but the user is in a dts - can an
include overwrite that status?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)