linux-kernel - Re: [PATCH 1/2] watchdog: simatic-ipc-wdt: make IO region access of one model muxed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230710205457.6894d978@md1za8fc.ad001.siemens.net>
Date:   Mon, 10 Jul 2023 20:54:57 +0200
From:   Henning Schild <henning.schild@...mens.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Jean Delvare <jdelvare@...e.com>,
        linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Tobias Schaffner <tobias.schaffner@...mens.com>,
        Gerd Haeussler <gerd.haeussler.ext@...mens.com>
Subject: Re: [PATCH 1/2] watchdog: simatic-ipc-wdt: make IO region access of
 one model muxed

Am Mon, 10 Jul 2023 06:45:14 -0700
schrieb Guenter Roeck <linux@...ck-us.net>:

> On Mon, Jul 10, 2023 at 03:33:45PM +0200, Hans de Goede wrote:
> > Hi Guenter,
> > 
> > On 7/6/23 18:03, Guenter Roeck wrote:  
> > > On 7/6/23 08:48, Henning Schild wrote:  
> > >> The IO region used for the watchdog also hold CMOS battery
> > >> monitoring information. Make the access muxed so that a hwmon
> > >> driver can use the region as well.
> > >>
> > >> Signed-off-by: Henning Schild <henning.schild@...mens.com>  
> > > 
> > > Acked-by: Guenter Roeck <linux@...ck-us.net>  
> > 
> > Thank you. Is it ok if I pick up his patch and merge it together
> > with 2/2 through the pdx86 tree ?
> >   
> 
> Yes. That was my assumption.

Thanks guys. Cant believe i made it with v1. Getting better at this ;)

Henning

> Guenter
> 
> > Regards,
> > 
> > Hans
> > 
> >   
> > >   
> > >> ---
> > >>   drivers/watchdog/simatic-ipc-wdt.c | 9 ++++++---
> > >>   1 file changed, 6 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/drivers/watchdog/simatic-ipc-wdt.c
> > >> b/drivers/watchdog/simatic-ipc-wdt.c index
> > >> 6599695dc672..cdc1a2e15180 100644 ---
> > >> a/drivers/watchdog/simatic-ipc-wdt.c +++
> > >> b/drivers/watchdog/simatic-ipc-wdt.c @@ -155,9 +155,8 @@ static
> > >> int simatic_ipc_wdt_probe(struct platform_device *pdev) switch
> > >> (plat->devmode) { case SIMATIC_IPC_DEVICE_227E:
> > >> -        if (!devm_request_region(dev,
> > >> gp_status_reg_227e_res.start,
> > >> -                     resource_size(&gp_status_reg_227e_res),
> > >> -                     KBUILD_MODNAME)) {
> > >> +        res = &gp_status_reg_227e_res;
> > >> +        if (!request_muxed_region(res->start,
> > >> resource_size(res), res->name)) { dev_err(dev,
> > >>                   "Unable to register IO resource at %pR\n",
> > >>                   &gp_status_reg_227e_res);
> > >> @@ -210,6 +209,10 @@ static int simatic_ipc_wdt_probe(struct
> > >> platform_device *pdev) if (wdd_data.bootstatus)
> > >>           dev_warn(dev, "last reboot caused by watchdog
> > >> reset\n");
> > >>   +    if (plat->devmode == SIMATIC_IPC_DEVICE_227E)
> > >> +        release_region(gp_status_reg_227e_res.start,
> > >> +                   resource_size(&gp_status_reg_227e_res));
> > >> +
> > >>       watchdog_set_nowayout(&wdd_data, nowayout);
> > >>       watchdog_stop_on_reboot(&wdd_data);
> > >>       return devm_watchdog_register_device(dev, &wdd_data);  
> > >   
> >