linux-kernel - Re: [PATCH v2 3/3] dyndbg: add source filename to prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKxc9BiZIS5GHmV9@bombadil.infradead.org>
Date:   Mon, 10 Jul 2023 12:33:08 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Jason Baron <jbaron@...mai.com>, Jim Cromie <jim.cromie@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 3/3] dyndbg: add source filename to prefix

On Sun, Jul 09, 2023 at 11:18:00PM +0200, Thomas Weißschuh wrote:
> Printing the line number without the file is of limited usefulness.
> 
> Knowing the filename also makes it also easier to relate the logged
> information to the controlfile.
> 
> Example:
> 
>     # modprobe test_dynamic_debug
>     # echo 'file test_dynamic_debug.c =pfsl' > /proc/dynamic_debug/control
>     # echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints
>     # dmesg | tail -2
>     [   71.802212] do_cats:lib/test_dynamic_debug.c:103: test_dd: doing categories
>     [   71.802227] do_levels:lib/test_dynamic_debug.c:123: test_dd: doing levels
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> Acked-by: Jim Cromie <jim.cromie@...il.com>
> Acked-by: Jason Baron <jbaron@...mai.com>

Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>

  Luis