linux-kernel - Re: [PATCH for 6.5] workqueue: Warn attempt to flush system-wide workqueues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKxsyh0QlqQfQRD0@slm.duckdns.org>
Date:   Mon, 10 Jul 2023 10:40:42 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Lai Jiangshan <jiangshanlai@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH for 6.5] workqueue: Warn attempt to flush system-wide
 workqueues.

On Fri, Jun 30, 2023 at 09:28:53PM +0900, Tetsuo Handa wrote:
> Based on commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using
> a macro"), all in-tree users stopped flushing system-wide workqueues.
> Therefore, start emitting runtime message so that all out-of-tree users
> will understand that they need to update their code.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Applied to wq/for-6.6.

> After this patch, flush_workqueue(wq) where wq cannot be determined at build
> time will not get runtime warning. Should we now start checking wq at run time
> so that we get runtime warning when wq is system-wide?

Yeah, we can add an internal flag for these standard workqueues and trigger
warning when somebody tries to flush them.

Thanks.

-- 
tejun