linux-kernel - Re: [PATCH] selftests: Fix arm64 test installation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec86c0eb-5c6d-48a2-c216-ec4f40710ca1@nvidia.com>
Date:   Mon, 10 Jul 2023 14:31:56 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Shuah Khan <shuah@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anders Roxell <anders.roxell@...aro.org>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        <linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] selftests: Fix arm64 test installation

On 7/10/23 14:20, Mark Brown wrote:
> On Mon, Jul 10, 2023 at 01:22:41PM -0700, John Hubbard wrote:
> 
>> There are 30 or 50 other pre-existing arm64 selftest build failures which were
>> quite misleading at first, until I got into the "right" selftests mindset of,
>> "massive swaths of selftests are broken, deal with it". :)
> 
> There are no such thing as far as I am aware - the arm64 selftests are
> *very* actively used by a range of people and CI systems, I certainly
> build them pretty consistently and am aware of no build failures with
> either GCC or clang.  You do need to install the headers to get the
> current APIs but until your commit everything was building cleanly.
> 
> If you are seeing any problems please report them.

oh wow, yes, I am! It's on a slightly older installation (gcc version
8.5.0 20210514 (Red Hat 8.5.0-18)), but there are a lot of basic build
failures, I'll get them together and send out a note.

Meanwhile, if you would like to try a quick fix, I have one that fixes
the problem on my system. I'm inclined to dress it up with a comment
that explains it (with a "TODO: stop using recursive Make here"), and
send it out as an actual fix:

diff --git a/tools/testing/selftests/arm64/Makefile b/tools/testing/selftests/arm64/Makefile
index 9460cbe81bcc..ace8b67fb22d 100644
--- a/tools/testing/selftests/arm64/Makefile
+++ b/tools/testing/selftests/arm64/Makefile
@@ -42,7 +42,7 @@ run_tests: all
         done
  
  # Avoid any output on non arm64 on emit_tests
-emit_tests: all
+emit_tests:
         @for DIR in $(ARM64_SUBTARGETS); do                             \
                 BUILD_TARGET=$(OUTPUT)/$$DIR;                   \
                 make OUTPUT=$$BUILD_TARGET -C $$DIR $@;         \
<blueforge> arm64 (master)$


thanks,
-- 
John Hubbard
NVIDIA