linux-kernel - RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR21MB16887E35CE80D293DE2243E0D730A@BYAPR21MB1688.namprd21.prod.outlook.com>
Date:   Mon, 10 Jul 2023 05:20:56 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     Sui Jingfeng <suijingfeng@...ngson.cn>,
        Deepak Rawat <drawat.floss@...il.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Javier Martinez Canillas <javierm@...hat.com>,
        Arnd Bergmann <arnd@...db.de>
CC:     "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: RE: [PATCH] drm/hyperv: Fix a compilation issue because of not
 including screen_info.h

From: Sui Jingfeng <suijingfeng@...ngson.cn> Sent: Sunday, July 9, 2023 3:05 AM
> 
>    drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
> in this function)
>     1033 |                 base = screen_info.lfb_base;
>          |                        ^~~~~~~~~~~
>    drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
> only once for each function it appears in
> --
>    drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
> (first use in this function)
>       75 |         drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>          |                                                      ^~~~~~~~~~~
>    drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
> reported only once for each function it appears in
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
>  drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
>  #include <linux/hyperv.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> +#include <linux/screen_info.h>
> 
>  #include <drm/drm_aperture.h>
>  #include <drm/drm_atomic_helper.h>
> --
> 2.25.1

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>