linux-kernel - Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti Video Input Interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6251cf1b-6428-81e5-50b2-d65cd514063a@linaro.org>
Date:   Mon, 10 Jul 2023 08:05:25 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     yuji2.ishikawa@...hiba.co.jp, lkp@...el.com, hverkuil@...all.nl,
        sakari.ailus@....fi, laurent.pinchart@...asonboard.com,
        mchehab@...nel.org, robh+dt@...nel.org, krzk@...nel.org,
        conor+dt@...nel.org, nobuhiro1.iwamatsu@...hiba.co.jp
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
 Video Input Interface driver

On 10/07/2023 02:16, yuji2.ishikawa@...hiba.co.jp wrote:
>> -----Original Message-----
>> From: kernel test robot <lkp@...el.com>
>> Sent: Tuesday, June 20, 2023 9:58 PM
>> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
>> <yuji2.ishikawa@...hiba.co.jp>; Hans Verkuil <hverkuil@...all.nl>; Sakari
>> Ailus <sakari.ailus@....fi>; Laurent Pinchart
>> <laurent.pinchart@...asonboard.com>; Mauro Carvalho Chehab
>> <mchehab@...nel.org>; Rob Herring <robh+dt@...nel.org>; Krzysztof
>> Kozlowski <krzk@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
>> iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ)
>> <nobuhiro1.iwamatsu@...hiba.co.jp>
>> Cc: llvm@...ts.linux.dev; oe-kbuild-all@...ts.linux.dev;
>> linux-media@...r.kernel.org; devicetree@...r.kernel.org;
>> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
>> Video Input Interface driver
>>
>> Hi Yuji,
>>
>> kernel test robot noticed the following build errors:
>>
>> [auto build test ERROR on media-tree/master] [also build test ERROR on
>> linus/master sailus-media-tree/streams v6.4-rc7 next-20230620] [If your patch
>> is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Yuji-Ishikawa/dt-bindings-me
>> dia-platform-visconti-Add-Toshiba-Visconti-Video-Input-Interface-bindings/20
>> 230620-120839
>> base:   git://linuxtv.org/media_tree.git master
>> patch link:
>> https://lore.kernel.org/r/20230620031111.3776-3-yuji2.ishikawa%40toshiba.co.j
>> p
>> patch subject: [PATCH v6 2/5] media: platform: visconti: Add Toshiba Visconti
>> Video Input Interface driver
>> config: x86_64-buildonly-randconfig-r001-20230620
>> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
>> kp@...el.com/config)
>> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git
>> 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
>> reproduce:
>> (https://download.01.org/0day-ci/archive/20230620/202306202006.FUjZfd9O-l
>> kp@...el.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of the
>> same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Closes:
>> | https://lore.kernel.org/oe-kbuild-all/202306202006.FUjZfd9O-lkp@intel.
>> | com/
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from <built-in>:1:
>>    In file included from ./usr/include/linux/visconti_viif.h:12:
>>>> usr/include/linux/videodev2.h:2464:20: error: field has incomplete type
>> 'struct timespec'
>>            struct timespec                 timestamp;
>>                                            ^
>>    usr/include/linux/videodev2.h:2464:9: note: forward declaration of 'struct
>> timespec'
>>            struct timespec                 timestamp;
>>                   ^
>>    1 error generated.
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
> 
> I could not reproduce the error with the steps had been specified.
> 
> * archived config file didn't compile Visconti VIIF driver (at least, COMPILE_TEST is needed)

That's not true. The config has enabled CONFIG_VIDEO_VISCONTI_VIIF, so
your reproduction steps were not correct (e.g. wrong arch, compiler etc).

> * the error message didn't appear even if I add some options to config file.
> * Environment:
>   * OS: Ubuntu 22.04
>   * compiler: Ubuntu clang version 15.07

Different compilers can have have or not have warnings, but it does not
allow to ignore this warning. You can analyze the code even without
reproducing it, if the reproduction is a problem.

Best regards,
Krzysztof