linux-kernel - Re: [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKurQVJotCwBSHkD@infradead.org>
Date:   Sun, 9 Jul 2023 23:54:57 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Andreas Hindborg <nmi@...aspace.dk>
Cc:     Ming Lei <ming.lei@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Hans Holmberg <Hans.Holmberg@....com>,
        Andreas Hindborg <a.hindborg@...sung.com>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Johannes Thumshirn <jth@...nel.org>,
        Damien Le Moal <dlemoal@...nel.org>,
        Matias Bjorling <Matias.Bjorling@....com>,
        Christoph Hellwig <hch@...radead.org>,
        Minwoo Im <minwoo.im.dev@...il.com>, gost.dev@...sung.com,
        Aravind Ramesh <Aravind.Ramesh@....com>
Subject: Re: [PATCH v7 1/3] ublk: add opcode offsets for DRV_IN/DRV_OUT

On Mon, Jul 10, 2023 at 08:46:04AM +0200, Andreas Hindborg wrote:
> +#define		UBLK_IO_OP_WRITE_ZEROES		5
> +/*
> + * Ublk passthrough operation code ranges, and each passthrough operation
> + * provides generic interface between ublk kernel driver and ublk userspace, and
> + * this interface is usually used for handling generic block layer request, such
> + * as command of zoned report zones. Passthrough operation is only needed iff
> + * ublk kernel driver has to be involved for handling this operation.
> + */
> +#define		__UBLK_IO_OP_DRV_IN_START	32
> +#define		__UBLK_IO_OP_DRV_IN_END		96
> +#define		__UBLK_IO_OP_DRV_OUT_START	__UBLK_IO_OP_DRV_IN_END
> +#define		__UBLK_IO_OP_DRV_OUT_END	160

I guess I was just a little late to catch this before your resend,
sorry.  Please look at my comment on the last iteration.