linux-kernel - Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 15:23:35 +0800
From:   Alina Yu <alina_yu@...htek.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     <broonie@...nel.org>, <linux-kernel@...r.kernel.org>,
        <cy_huang@...htek.com>, <alina_yu@...htek.com>
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC

On Mon, Jul 10, 2023 at 08:02:39AM +0200, Krzysztof Kozlowski wrote:
> On 10/07/2023 05:08, Alina Yu wrote:
> >> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
> >> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
> >>
> >> Is it more understandable if I modify that to enum ? And description will be like this
> >>
> >> richtek,mtp-sel:
> >>   enum: [0, 1]
> >>     description: |
> >>       vout register selection besed on this value.
> >>       0 - Using DVS0 register setting to adjust vout
> >>       1 - Using DVS1 register setting to adjust vout
> >>
> > 
> > May I ask one more question ?
> > If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
> > It will be like this,
> > 
> > richtek,mtp-sel-high:
> >   type: boolean
> >   description:
> >   vout register selection besed on this value.
> >   0 - Using DVS0 register setting to adjust vout
> >   1 - Using DVS1 register setting to adjust vout
> 
> You don't have 0 or 1 values in such case. The property can be bool, but
> description is not good.
> 

May I modify the description like this ?

richtek,mtp-sel-high:
  type: boolean
  description:
  vout register selection besed on this boolean value.
  false - Using DVS0 register setting to adjust vout
  true - Using DVS1 register setting to adjust vout


BR,
Alina.