linux-kernel - Re: [PATCH] cpu/SMT: Fix cpu_smt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878rbo5ibi.fsf@redhat.com>
Date:   Mon, 10 Jul 2023 09:36:33 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Zhang Rui <rui.zhang@...el.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org
Subject: Re: [PATCH] cpu/SMT: Fix cpu_smt_possible() comment

Zhang Rui <rui.zhang@...el.com> writes:

> The comment of cpu_smt_possible() is not aligned with the changelog of
> commit e1572f1d08be ("cpu/SMT: create and export cpu_smt_possible()"),
> and it is wrong.
>
> Fix cpu_smt_possible() comment.
>
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
> ---
>  kernel/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/cpu.c b/kernel/cpu.c
> index 7e8f1b044772..f6811c857102 100644
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -676,7 +676,7 @@ static inline bool cpu_smt_allowed(unsigned int cpu)
>  	return !cpumask_test_cpu(cpu, &cpus_booted_once_mask);
>  }
>  
> -/* Returns true if SMT is not supported of forcefully (irreversibly) disabled */
> +/* Returns true if SMT is supported and not forcefully (irreversibly) disabled */
>  bool cpu_smt_possible(void)
>  {
>  	return cpu_smt_control != CPU_SMT_FORCE_DISABLED &&

The function must've had a different name in an earlier version of the
patch...

Thanks for catching this!

Reviewed-by: Vitaly Kuznetsov <vkuznets@...hat.com>

-- 
Vitaly