linux-kernel - Re: [RFC PATCH 1/2] fpga: region: fix kernel-doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKu7yj1+QumQ9DlM@yilunxu-OptiPlex-7050>
Date:   Mon, 10 Jul 2023 16:05:30 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>, marpagan@...hat.com
Cc:     Marco Pagani <marpagan@...hat.com>,
        Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org,
        linux-fpga@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] fpga: region: fix kernel-doc

On 2023-07-06 at 14:30:34 -0700, Randy Dunlap wrote:
> Hi--
> 
> On 7/6/23 07:27, Marco Pagani wrote:
> > - Fix the following warnings issued by the kernel-doc script:
> > 
> > drivers/fpga/fpga-region.c:46: warning: No description found for return value of 'fpga_region_get'
> > drivers/fpga/fpga-region.c:97: warning: No description found for return value of 'fpga_region_program_fpga'
> > drivers/fpga/fpga-region.c:295: warning: No description found for return value of 'fpga_region_init'
> > 
> > - Remove the "and registers a reconfig notifier" part from the description
> >   of fpga_region_init() since it does not register an of_overlay notifier
> >   anymore.
> > 
> > - Remove the outdated "if @np is not an FPGA Region" case from the return
> >   description of fpga_region_get() and replace it with the case when
> >   try_module_get() fails.
> > 
> > Signed-off-by: Marco Pagani <marpagan@...hat.com>
> 
> Looks good. Thanks.
> 
> Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied.

BTW: No need to have RFC if you think it is ready for full review.