linux-kernel - Re: [PATCH HID v1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168897796423.315593.17705252764263719274.b4-ty@kernel.org>
Date:   Mon, 10 Jul 2023 10:32:44 +0200
From:   Benjamin Tissoires <bentiss@...nel.org>
To:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH HID v1] HID: nvidia-shield: Pack inner/related
 declarations in HOSTCMD reports

On Tue, 04 Jul 2023 23:04:14 -0700, Rahul Rameshbabu wrote:
> Match alignment information in composite type declarations used by packed
> HOSTCMD report structures. Compiler packing attribute is not recursive for
> inner declarations. Mismatched alignment information can cause undefined
> behavior in code generated for accessing composite type members. struct
> pointers passed to thunderstrike_parse_board_info_payload and
> thunderstrike_parse_haptics_payload are an example of this being
> potentially problematic since alignment information from the packed HOSTCMD
> report is lost.
> 
> [...]

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.5/upstream-fixes), thanks!

[1/1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports
      https://git.kernel.org/hid/hid/c/8bcf314b92ed

Cheers,
-- 
Benjamin Tissoires <bentiss@...nel.org>