[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230710083400.c24jnxxykxjsl47q@blmsp>
Date: Mon, 10 Jul 2023 10:34:00 +0200
From: Markus Schneider-Pargmann <msp@...libre.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Chun-Jie Chen <chun-jie.chen@...iatek.com>,
Tinghan Shen <tinghan.shen@...iatek.com>,
Fabien Parent <parent.f@...il.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Fabien Parent <fparent@...libre.com>
Subject: Re: [PATCH v6 8/8] soc: mediatek: pm-domains: Add support for MT8365
Hi Angelo,
On Tue, Jul 04, 2023 at 12:31:23PM +0200, AngeloGioacchino Del Regno wrote:
> Il 27/06/23 15:10, Markus Schneider-Pargmann ha scritto:
> > From: Fabien Parent <fparent@...libre.com>
> >
> > Add the needed board data to support MT8365 SoC.
> >
> > Signed-off-by: Fabien Parent <fparent@...libre.com>
> > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
>
>
>
> ..snip..
>
>
> > diff --git a/include/linux/soc/mediatek/infracfg.h b/include/linux/soc/mediatek/infracfg.h
> > index 07f67b3d8e97..f853397697b5 100644
> > --- a/include/linux/soc/mediatek/infracfg.h
> > +++ b/include/linux/soc/mediatek/infracfg.h
> > @@ -2,6 +2,47 @@
> > #ifndef __SOC_MEDIATEK_INFRACFG_H
> > #define __SOC_MEDIATEK_INFRACFG_H
> > +#define MT8365_INFRA_TOPAXI_PROTECTEN_STA1 0x228
> > +#define MT8365_INFRA_TOPAXI_PROTECTEN_SET 0x2a0
> > +#define MT8365_INFRA_TOPAXI_PROTECTEN_CLR 0x2a4
> > +# define MT8365_INFRA_TOPAXI_PROTECTEN_MM_M0 BIT(1)
>
> Personally, I like this kind of indentation, but more like
>
> #define REGADDRESS
> #define REGMASK
>
> instead of
>
> #define REGADDRESS
> # define REGMASK
>
> ...but this doesn't count, because this header doesn't follow *either* formats,
> not my preferred, nor yours: this means that, for consistency, you have to follow
> what's in there already, so you have to change that to
>
> #define REGADDRESS
> #define REGMASK
>
> ...so please change that to retain consistency across the infracfg.h header,
> after which:
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Thank you for your review. I fixed both issues you pointed out for the
next version.
Best,
Markus
Powered by blists - more mailing lists