linux-kernel - Re: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKvHRLJlpF9YCnPA@yilunxu-OptiPlex-7050>
Date:   Mon, 10 Jul 2023 16:54:28 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Michal Simek <michal.simek@....com>
Cc:     Yangtao Li <frank.li@...o.com>, Moritz Fischer <mdf@...nel.org>,
        Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
        linux-fpga@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] fpga: zynq-fpga: Convert to
 devm_platform_ioremap_resource()

On 2023-07-07 at 06:55:49 +0200, Michal Simek wrote:
> 
> 
> On 7/5/23 11:46, Yangtao Li wrote:
> > Use devm_platform_ioremap_resource() to simplify code.
> > 
> > Signed-off-by: Yangtao Li <frank.li@...o.com>
> > ---
> >   drivers/fpga/zynq-fpga.c | 4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> > index f8214cae9b6e..96611d424a10 100644
> > --- a/drivers/fpga/zynq-fpga.c
> > +++ b/drivers/fpga/zynq-fpga.c
> > @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> >   	struct device *dev = &pdev->dev;
> >   	struct zynq_fpga_priv *priv;
> >   	struct fpga_manager *mgr;
> > -	struct resource *res;
> >   	int err;
> >   	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> > @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev)
> >   		return -ENOMEM;
> >   	spin_lock_init(&priv->dma_lock);
> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	priv->io_base = devm_ioremap_resource(dev, res);
> > +	priv->io_base = devm_platform_ioremap_resource(pdev, 0);
> >   	if (IS_ERR(priv->io_base))
> >   		return PTR_ERR(priv->io_base);
> 
> Acked-by: Michal Simek <michal.simek@....com>

Acked-by: Xu Yilun <yilun.xu@...el.com>

Applied.

> 
> M