linux-kernel - Re: [PATCH v4 3/6] iio: adc: meson: move meson_sar_adc_set_chan7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKvPMXu3Q8U18FG8@smile.fi.intel.com>
Date:   Mon, 10 Jul 2023 12:28:17 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     George Stark <gnstark@...rdevices.ru>
Cc:     jic23@...nel.org, lars@...afoo.de, neil.armstrong@...aro.org,
        khilman@...libre.com, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, nuno.sa@...log.com,
        linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        kernel@...rdevices.ru
Subject: Re: [PATCH v4 3/6] iio: adc: meson: move meson_sar_adc_set_chan7_mux
 routine upper

On Fri, Jul 07, 2023 at 06:27:40PM +0300, George Stark wrote:
> meson_sar_adc_set_chan7_mux is a basic routine writing single register,

We refer to the functions as func().
Mind the parentheses.

"for writing a"

> and defined as static. It moved up so it could be used in more places.

"Move it up, so"

-- 
With Best Regards,
Andy Shevchenko