linux-kernel - Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 11:08:58 +0800
From:   Alina Yu <alina_yu@...htek.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
CC:     <broonie@...nel.org>, <linux-kernel@...r.kernel.org>,
        <cy_huang@...htek.com>, <alina_yu@...htek.com>
Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: rtq2208: Add Richtek
 RTQ2208 SubPMIC

Hi, Krzystof

On Thu, Jul 06, 2023 at 06:30:40PM +0800, Alina Yu wrote:
> On Wed, Jul 05, 2023 at 07:58:53PM +0200, Krzysztof Kozlowski wrote:
> > On 05/07/2023 17:27, alina_yu@...htek.com wrote:
> > > From: alinayu <alina_yu@...htek.com>
> > > 
> > > Add bindings for Richtek RTQ2208 IC controlled SubPMIC
> > 
> 
> ...
> 
> > > +      Buck and ldo vout selection is based on this value.
> > > +      There are two independently programmable voltage settings named as mtp-sel0 and
> > > +      mtp-sel1 for RTQ2208 bucks vout voltage. 0 which means this property isn't present
> > > +      and 1 which means this property is present corresponds to different adjustable registers.
> > > +
> > > +      0 - DVS0 registers to adjust buck vout and BUCK_[A-H]_EN_NR_MTP_SEL0 register to en/disable vout.
> > > +      1 - DVS1 registers to adjust buck vout and BUCK_[A-H]_EN_NR_MTP_SEL1 register to en/disable vout.
> > 
> > I read it three times and still don't understand. This is bool, not 0/1,
> > so are these "0" refer to DVS0 or to presence of the property? Maybe
> > Mark will understand it, I don't get it.
> > 
> 
> Yes, "0" refers to DVS0 registers, and "1" refers to DVS1.
> and there is only DVS0 and DVS1, so I use boolean to check which one is used.
> 
> Is it more understandable if I modify that to enum ? And description will be like this
> 
> richtek,mtp-sel:
>   enum: [0, 1]
>     description: |
>       vout register selection besed on this value.
>       0 - Using DVS0 register setting to adjust vout
>       1 - Using DVS1 register setting to adjust vout
> 

May I ask one more question ?
If I modify the name into "richtek,mtp-sel-high", is that more understandable ?
It will be like this,

richtek,mtp-sel-high:
  type: boolean
  description:
  vout register selection besed on this value.
  0 - Using DVS0 register setting to adjust vout
  1 - Using DVS1 register setting to adjust vout

> 
> > 
> > 
> 
> BR,
> Alina