linux-kernel - Re: [PATCH] signal: remove duplicate include header in signal.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f5a3d4c-34fb-9d9b-444f-da8f7389ab76@shopee.com>
Date:   Mon, 10 Jul 2023 18:11:39 +0800
From:   Haifeng Xu <haifeng.xu@...pee.com>
To:     ye.xingchen@....com.cn, rafael.j.wysocki@...el.com
Cc:     peterz@...radead.org, ebiederm@...ssion.com, elver@...gle.com,
        tglx@...utronix.de, michael.christie@...cle.com,
        viro@...iv.linux.org.uk, mcgrof@...nel.org, dvyukov@...gle.com,
        vincent.whitchurch@...s.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] signal: remove duplicate include header in signal.c

On 2023/7/10 15:23, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> linux/file.h is included more than once.

Can you point out which files have contained file.h?
Though file.h is included more than once, but it has used the macro "#ifndef / #define" to avoid redefinition.
So what’s your concern about this?

Thanks, Haifeng.

> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>
> ---
>  kernel/signal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index 9a3ff8157ceb..b1da4e81bde6 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -25,7 +25,6 @@
>  #include <linux/mm.h>
>  #include <linux/proc_fs.h>
>  #include <linux/tty.h>
> -#include <linux/file.h>
>  #include <linux/binfmts.h>
>  #include <linux/coredump.h>
>  #include <linux/security.h>