[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <13d4c853-ed7b-f0f5-dffb-a7811f2da249@suse.de>
Date: Mon, 10 Jul 2023 13:59:25 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Jani Nikula <jani.nikula@...ux.intel.com>,
suijingfeng <suijingfeng@...ngson.cn>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Li Yi <liyi@...ngson.cn>
Cc: loongson-kernel@...ts.loongnix.cn, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org,
Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] drm/loongson: Remove a useless check in
cursor_plane_atomic_async_check()
Hi
Am 10.07.23 um 13:46 schrieb Jani Nikula:
> On Mon, 10 Jul 2023, suijingfeng <suijingfeng@...ngson.cn> wrote:
>> On 2023/7/10 18:39, Thomas Zimmermann wrote:
>>> but that driver is not yet in our tree?
>>>
>>
>> I already applied(push) drm/loongson driver to drm-misc-next branch,
>>
>> What do you means that by "not yet in our tree", linux kernel side?
>>
>> Am I missing something ?
>
> Hmm, indeed there's commit f39db26c5428 ("drm: Add kms driver for
> loongson display controller")... but it only has one Acked-by from
> Thomas that I can't find on any lists, and zero Reviewed-by.
>
> Usually, the bigger the change, the more acks/reviews you need. Did
> Thomas really ack this to be merged without recorder reviews? :o
Should be OK; it's an isolated driver. I did a review early on and after
~13 revisions I asked for it to be merged. It's actually a bit hard to
find reviewers.
Best regards
Thomas
>
>
> BR,
> Jani.
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)
Powered by blists - more mailing lists