linux-kernel - Re: [PATCH] Input: tegra-kbc - use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 15:11:23 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Laxman Dewangan <ldewangan@...dia.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-input@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: tegra-kbc - use devm_platform_ioremap_resource

On Sun, Jul 09, 2023 at 03:41:08PM +0200, Martin Kaiser wrote:
> devm_platform_get_and_ioremap_resource maps a resource and returns its
> physical address. If we don't need the physical address, we should call
> devm_platform_ioremap_resource instead.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>  drivers/input/keyboard/tegra-kbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Different variations of these have been going around for a while now. I
don't really see much use in these tiny conversions.

But the patch also isn't wrong, so while I'm at it:

Acked-by: Thierry Reding <treding@...dia.com>


> 
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index d5a6c7d8eb25..c9a823ea45d0 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -640,7 +640,7 @@ static int tegra_kbc_probe(struct platform_device *pdev)
>  
>  	timer_setup(&kbc->timer, tegra_kbc_keypress_timer, 0);
>  
> -	kbc->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> +	kbc->mmio = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(kbc->mmio))
>  		return PTR_ERR(kbc->mmio);
>  
> -- 
> 2.30.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)