linux-kernel - Re: [PATCH v3 0/2] perf probe: fix regression introduced by switch to die_get_decl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <090d1bcb-608b-1aa3-7a59-f2b09ff0061e@leemhuis.info>
Date:   Mon, 10 Jul 2023 15:49:49 +0200
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Linux regressions mailing list <regressions@...ts.linux.dev>
Cc:     Georg Müller <georgmueller@....net>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] perf probe: fix regression introduced by switch to
 die_get_decl_file

On 10.07.23 15:44, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jul 10, 2023 at 02:32:28PM +0200, Linux regression tracking (Thorsten Leemhuis) escreveu:
>> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
>> for once, to make this easily accessible to everyone.
>>
>> Masami, Arnaldo, what's up here? Georg (who is not a regular
>> contributor) afaics found a regression in a commit you
>> authored/committed and even provided a patch-set to fix it (the first
>> one nearly four weeks ago, e.g. before the merge window started), but
>> hasn't received much support from your side to get this in. Could you
>> please look into this to get this cleared up? Or am I missing something
>> and progress to fix this has been made?
> 
> I'm back from a 2 week vacation,

Welcome back and hope you found some rest.

> going thru the pile, probably fell thru
> the cracks and Namyung, that processed patches while I was away didn't
> notice it either.
> 
> I'm checking,

Great, many thx! Ciao, Thorsten

>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> --
>> Everything you wanna know about Linux kernel regression tracking:
>> https://linux-regtracking.leemhuis.info/about/#tldr
>> If I did something stupid, please tell me, as explained on that page.
>>
>>
>> On 28.06.23 10:45, Georg Müller wrote:
>>> When switching from dwarf_decl_file() to die_get_decl_file(), a regression
>>> was introduced when having a binary where the DWARF info is split to
>>> multiple CUs. It is not possible to add probes to certain functions.
>>>
>>> These patches introduce a testcase which shows the current regression
>>> and a fix for the issue
>>>
>>> Signed-off-by: Georg Müller <georgmueller@....net>
>>> Link: https://lore.kernel.org/r/5a00d5a5-7be7-ef8a-4044-9a16249fff25@gmx.net/
>>>
>>> ---
>>> Changes in v2:
>>>  - Add testcase
>>>
>>> Changes in v3:
>>>  - start new thread
>>>  - add stable to cc
>>>
>>> Georg Müller (2):
>>>   perf probe: add test for regression introduced by switch to
>>>     die_get_decl_file
>>>   perf probe: read DWARF files from the correct CU
>>>
>>>  .../shell/test_uprobe_from_different_cu.sh    | 77 +++++++++++++++++++
>>>  tools/perf/util/dwarf-aux.c                   |  4 +-
>>>  2 files changed, 80 insertions(+), 1 deletion(-)
>>>  create mode 100755 tools/perf/tests/shell/test_uprobe_from_different_cu.sh
>>>
>>> --
>>> 2.41.0
>>>
>>>
>>>
>