linux-kernel - Re: [PATCH 50/53] interconnect: qcom: sm8350: Point display paths to the display RSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <849dcb13-8059-f50b-4f5c-d8946f7c598c@linaro.org>
Date:   Tue, 11 Jul 2023 17:17:21 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Georgi Djakov <djakov@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 50/53] interconnect: qcom: sm8350: Point display paths to
 the display RSC

On 11/07/2023 15:18, Konrad Dybcio wrote:
> The _DISP paths are expected to go through the DISP RSC. Point them to the
> correct place.
> 
> Fixes: d26a56674497 ("interconnect: qcom: Add SM8350 interconnect provider driver")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>   drivers/interconnect/qcom/sm8350.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/sm8350.c b/drivers/interconnect/qcom/sm8350.c
> index c48f96ff8575..0466ba5d939a 100644
> --- a/drivers/interconnect/qcom/sm8350.c
> +++ b/drivers/interconnect/qcom/sm8350.c
> @@ -1609,7 +1609,7 @@ static struct qcom_icc_bcm bcm_sn14 = {
>   static struct qcom_icc_bcm bcm_acv_disp = {
>   	.name = "ACV",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,

Shouldn't this value come from a enum? Otherwise a magic '1' is... a magic.

>   	.num_nodes = 1,
>   	.nodes = { &ebi_disp },
>   };
> @@ -1617,7 +1617,7 @@ static struct qcom_icc_bcm bcm_acv_disp = {
>   static struct qcom_icc_bcm bcm_mc0_disp = {
>   	.name = "MC0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &ebi_disp },
>   };
> @@ -1625,7 +1625,7 @@ static struct qcom_icc_bcm bcm_mc0_disp = {
>   static struct qcom_icc_bcm bcm_mm0_disp = {
>   	.name = "MM0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_mem_noc_hf_disp },
>   };
> @@ -1633,7 +1633,7 @@ static struct qcom_icc_bcm bcm_mm0_disp = {
>   static struct qcom_icc_bcm bcm_mm1_disp = {
>   	.name = "MM1",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 2,
>   	.nodes = { &qxm_mdp0_disp, &qxm_mdp1_disp },
>   };
> @@ -1641,7 +1641,7 @@ static struct qcom_icc_bcm bcm_mm1_disp = {
>   static struct qcom_icc_bcm bcm_mm4_disp = {
>   	.name = "MM4",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_mem_noc_sf_disp },
>   };
> @@ -1649,7 +1649,7 @@ static struct qcom_icc_bcm bcm_mm4_disp = {
>   static struct qcom_icc_bcm bcm_mm5_disp = {
>   	.name = "MM5",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qxm_rot_disp },
>   };
> @@ -1657,7 +1657,7 @@ static struct qcom_icc_bcm bcm_mm5_disp = {
>   static struct qcom_icc_bcm bcm_sh0_disp = {
>   	.name = "SH0",
>   	.keepalive = false,
> -	.voter_idx = 0,
> +	.voter_idx = 1,
>   	.num_nodes = 1,
>   	.nodes = { &qns_llcc_disp },
>   };
> 

-- 
With best wishes
Dmitry