[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3310eb5b3c944434b6e3b53750f1801f510811f2.camel@hotmail.com>
Date: Tue, 11 Jul 2023 15:27:42 +0000
From: donmor <donmor3000@...mail.com>
To: "chenhuacai@...nel.org" <chenhuacai@...nel.org>
CC: "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
"kernel@...0n.name" <kernel@...0n.name>,
"yangtiezhu@...ngson.cn" <yangtiezhu@...ngson.cn>,
"zhoubinbin@...ngson.cn" <zhoubinbin@...ngson.cn>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"ardb@...nel.org" <ardb@...nel.org>,
"tangyouling@...ngson.cn" <tangyouling@...ngson.cn>
Subject: Re: [PATCH v3] LoongArch: Make CONFIG_CMDLINE work with
CONFIG_CMDLINE_EXTEND and CONFIG_CMDLINE_BOOTLOADER
在 2023-07-11星期二的 22:26 +0800,Huacai Chen写道:
...
> + if (IS_ENABLED(CONFIG_CMDLINE_EXTEND)) {
> > + strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> > + strlcat(boot_command_line, " ", COMMAND_LINE_SIZE);
> > + strlcat(boot_command_line, init_command_line, COMMAND_LINE_SIZE);
> You can simply the logic:
> strlcat(boot_command_line, " ", COMMAND_LINE_SIZE);
> strlcat(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> And then modify the comments because you are appending built-in parts
> to bootloader parts.
>
I think the command line retrieved from bootloader should be placed after the
built-in one so that it can override params in the latter.
> > }
> > +
> > + if (IS_ENABLED(CONFIG_CMDLINE_BOOTLOADER) && !boot_command_line[0])
> > + strscpy(boot_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> This should be removed if you want to keep the exact meaning of
> CONFIG_CMDLINE_BOOTLOADER.
>
> Huacai
>
Do you mean 'IS_ENABLED(CONFIG_CMDLINE_BOOTLOADER) && ' is not necessary? And I
think the rest of this part should be here, because CONFIG_CMDLINE_BOOTLOADER
won't append anything to boot_command_line unless it is empty, according to its
description.
Powered by blists - more mailing lists