linux-kernel - Re: [PATCH] of: Preserve "of-display" device name for compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de35c35-c00d-d21a-bcd1-dc878137eb94@gmx.de>
Date:   Tue, 11 Jul 2023 17:46:07 +0200
From:   Helge Deller <deller@....de>
To:     Thomas Zimmermann <tzimmermann@...e.de>,
        Rob Herring <robh@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Michal Suchanek <msuchanek@...e.de>
Cc:     devicetree@...r.kernel.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Cyril Brulebois <cyril@...amax.com>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] of: Preserve "of-display" device name for compatibility

On 7/11/23 08:00, Thomas Zimmermann wrote:
>
>
> Am 10.07.23 um 19:40 schrieb Rob Herring:
>> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
>> as spotted by Frédéric Bonnard, the historical "of-display" device is
>> gone: the updated logic creates "of-display.0" instead, then as many
>> "of-display.N" as required.
>>
>> This means that offb no longer finds the expected device, which prevents
>> the Debian Installer from setting up its interface, at least on ppc64el.
>>
>> Fix this by keeping "of-display" for the first device and "of-display.N"
>> for subsequent devices.
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
>> Link: https://bugs.debian.org/1033058
>> Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
>> Cc: stable@...r.kernel.org
>> Cc: Cyril Brulebois <cyril@...amax.com>
>> Cc: Thomas Zimmermann <tzimmermann@...e.de>
>> Cc: Helge Deller <deller@....de>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

Acked-by: Helge Deller <deller@....de>

Who will pick up that patch?
Shall I take it via fbdev git tree?

Helge

>
>> ---
>>   drivers/of/platform.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
>> index 051e29b7ad2b..0c3475e7d2ff 100644
>> --- a/drivers/of/platform.c
>> +++ b/drivers/of/platform.c
>> @@ -552,7 +552,7 @@ static int __init of_platform_default_populate_init(void)
>>               if (!of_get_property(node, "linux,opened", NULL) ||
>>                   !of_get_property(node, "linux,boot-display", NULL))
>>                   continue;
>> -            dev = of_platform_device_create(node, "of-display.0", NULL);
>> +            dev = of_platform_device_create(node, "of-display", NULL);
>>               of_node_put(node);
>>               if (WARN_ON(!dev))
>>                   return -ENOMEM;
>