linux-kernel - Re: [PATCH 12/18] soc: starfive: Move the power-domain driver to the genpd dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230711-user-elves-9aebe921351e@spud>
Date:   Tue, 11 Jul 2023 17:07:28 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Walker Chen <walker.chen@...rfivetech.com>
Subject: Re: [PATCH 12/18] soc: starfive: Move the power-domain driver to the
 genpd dir

On Tue, Jul 11, 2023 at 03:57:49PM +0200, Ulf Hansson wrote:
> On Fri, 7 Jul 2023 at 17:51, Conor Dooley <conor@...nel.org> wrote:
> >
> > On Fri, Jul 07, 2023 at 04:04:28PM +0200, Ulf Hansson wrote:
> > > Cc: Walker Chen <walker.chen@...rfivetech.com>
> > > Cc: Conor Dooley <conor@...nel.org>
> > > Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> >

> > If you are not going to write a commit message with an explanation,
> 
> I will, sorry for being lazy.
> 
> > the least you could do is CC me on the cover letter.
> 
> Yes, I will soon post a new version and add you to the cover letter and patch 1.

Thanks. Obviously I was able to pull the message-id & look at lore etc,
but what goes for the goose, goes for the gander and all that.

> > > ---
> > >  MAINTAINERS                                                    | 2 +-
> > >  drivers/genpd/Makefile                                         | 1 +
> > >  drivers/genpd/starfive/Makefile                                | 2 ++
> > >  .../{soc/starfive/jh71xx_pmu.c => genpd/starfive/jh71xx-pmu.c} | 0
> > >  drivers/soc/starfive/Makefile                                  | 3 ---
> >
> > Why not also move the Kconfig entry while you are at it?
> 
> I just replied to Geert [1], who had similar questions. Hope that
> makes sense to you?

In general, it does explain why you did not do it.
I think that the Kconfig stuff should move too & the whole
soc/starfive directory should vanish, but that could be left for a
follow-up activity.

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)